we_universal Style "we_universal"

English support forum
v12mike
Equipo de Diseño
Mensajes: 29
Registrado: Dom Jun 11, 2017 11:22 am
Gender: None specified None specified

Style "we_universal"

Mensaje por v12mike » Dom Jun 11, 2017 11:30 am

I have just finished configuring our main forum with phpBB 3.2, and would like to share a bug fix and a couple of possible improvements to the style.

Is https://github.com/melvingb/we_universal the right place to make Pull Requests?

Avatar de Usuario
nextgen
Fundador del sitio
Mensajes: 152
Registrado: Sab Abr 30, 2011 12:04 am
Gender: Male Male

Re: Style "we_universal"

Mensaje por nextgen » Dom Jun 11, 2017 12:30 pm

Hi and welcome for my site, actually the style works correctly in version 3.2.0, in the portfolio section you can find the download at the moment I am correcting errors which I have reported, soon a new version will be launched.

The github repository it have outdated since it left me without a PC, soon I will update it.

v12mike
Equipo de Diseño
Mensajes: 29
Registrado: Dom Jun 11, 2017 11:22 am
Gender: None specified None specified

Re: Style "we_universal"

Mensaje por v12mike » Mié Jun 14, 2017 3:00 am

Can you make available your latest version/patches so that I can check and try them?

You might see our live forum at https://frenchcarforum.co.uk/forum

You may see that the responsive behaviour of the header bar and dashboard image are slightly modified

Avatar de Usuario
nextgen
Fundador del sitio
Mensajes: 152
Registrado: Sab Abr 30, 2011 12:04 am
Gender: Male Male

Re: Style "we_universal"

Mensaje por nextgen » Jue Jun 15, 2017 7:45 pm

Do I don't see anything weird, if you can be more specific I appreciate it, can you show me some image of the error that gives?

v12mike
Equipo de Diseño
Mensajes: 29
Registrado: Dom Jun 11, 2017 11:22 am
Gender: None specified None specified

Re: Style "we_universal"

Mensaje por v12mike » Vie Jun 16, 2017 4:41 am

Sorry, you misunderstood me. Those are elements that I have modified, and I think improved.

The notification bar behaves better on portrait phone screens and the dashboard image shrinks rather than being cropped.

I may have a different problem with the style, but I need to check it on prosilver before raising it here.

Avatar de Usuario
nextgen
Fundador del sitio
Mensajes: 152
Registrado: Sab Abr 30, 2011 12:04 am
Gender: Male Male

Re: Style "we_universal"

Mensaje por nextgen » Sab Jun 17, 2017 7:58 pm

Say me what changes you have made to see if they are viable to be added to future versions.

v12mike
Equipo de Diseño
Mensajes: 29
Registrado: Dom Jun 11, 2017 11:22 am
Gender: None specified None specified

Re: Style "we_universal"

Mensaje por v12mike » Lun Jun 19, 2017 12:49 pm

I have made a pull request with 3 commits.

Oops, had to revert the last one due to a side effect. I will try to fix this tomorrow.

v12mike
Equipo de Diseño
Mensajes: 29
Registrado: Dom Jun 11, 2017 11:22 am
Gender: None specified None specified

Re: Style "we_universal"

Mensaje por v12mike » Mar Jun 20, 2017 12:03 pm

OK, I think those are all the changes for now. Note that the "Fix for incorrect handling of postprofile on small screens" was reverted and should not be merged.

Avatar de Usuario
nextgen
Fundador del sitio
Mensajes: 152
Registrado: Sab Abr 30, 2011 12:04 am
Gender: Male Male

Re: Style "we_universal"

Mensaje por nextgen » Dom Jun 25, 2017 9:39 am

v12mike escribió:
Mar Jun 20, 2017 12:03 pm
OK, I think those are all the changes for now. Note that the "Fix for incorrect handling of postprofile on small screens" was reverted and should not be merged.
Thanks for you fix for this style... ;)

v12mike
Equipo de Diseño
Mensajes: 29
Registrado: Dom Jun 11, 2017 11:22 am
Gender: None specified None specified

Re: Style "we_universal"

Mensaje por v12mike » Lun Jun 26, 2017 7:06 am

Do you intend to get this style back into the phpbb.com styles database?

Responder